Disable CGO on build #359
Merged
Disable CGO on build #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acornett21
approved these changes
Jun 21, 2023
Signed-off-by: Jose R. Gonzalez <[email protected]>
komish
force-pushed
the
build-without-cgo
branch
from
4cb91c1
to
28761f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't seem to require CGO from what I can see. The golang builder image we use has a newer C toolchain than what's available in RHEL8. If disabling CGO isn't a problem, then this seems like the more compact route to take.
If this doesn't work out in the long term, we can just build from a RHEL8 golang builder image and that should also fix the problem.